Skip to content
Snippets Groups Projects

Added Flowdock integration support via a service.

Merged Added Flowdock integration support via a service.
github/fork/bladealslayer/feature/flowdock_integration into master
Merged gitlab-qa-bot requested to merge github/fork/bladealslayer/feature/flowdock_integration into master

Created by: bladealslayer

Added test for the FlowdockService.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Gemfile.lock
Unable to load the diff
  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: dzaporozhets

    this one is bad for gitlab. We use patched version of grit (see gitlab-grit). And this dependency will owerwrite our grit :(

    By Administrator on 2013-10-03T13:40:28 (imported from GitLab project)

    By Administrator on 2013-10-03T13:40:28 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot started a thread on commit e8b6974a
    • Gemfile.lock
    Unable to load the diff
    • gitlab-qa-bot
      gitlab-qa-bot @gitlab-qa-bot ·
      Author Owner

      Created by: bladealslayer

      Hmmm, ok. I am actually using this already in our setup. Do you know what would break because of it?

      By Administrator on 2013-10-03T13:40:28 (imported from GitLab project)

      By Administrator on 2013-10-03T13:40:28 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot started a thread on commit e8b6974a
    • Gemfile.lock
    Unable to load the diff
    • gitlab-qa-bot
      gitlab-qa-bot @gitlab-qa-bot ·
      Author Owner

      Created by: bladealslayer

      Do you think your Grit patches might be accepted upstream?

      By Administrator on 2013-10-03T13:40:28 (imported from GitLab project)

      By Administrator on 2013-10-03T13:40:28 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot started a thread on commit e8b6974a
    • Gemfile.lock
    Unable to load the diff
    • gitlab-qa-bot
      gitlab-qa-bot @gitlab-qa-bot ·
      Author Owner

      Created by: bladealslayer

      Would you accept the PR, if I set it to use a patched version of flowdock-git-hook that is maintained by me? I.e. I can patch flowdock-git-hook to use gitlab-grit, instead of grit.

      By Administrator on 2013-10-03T13:40:28 (imported from GitLab project)

      By Administrator on 2013-10-03T13:40:28 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot started a thread on commit e8b6974a
    • Gemfile.lock
    Unable to load the diff
    • gitlab-qa-bot
      gitlab-qa-bot @gitlab-qa-bot ·
      Author Owner

      Created by: dzaporozhets

      @bladealslayer its a possible workaround. if you push your version to rubygems - I'm ok

      By Administrator on 2013-10-03T13:40:28 (imported from GitLab project)

      By Administrator on 2013-10-03T13:40:28 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: bladealslayer

    @randx here's a version with a patched flowdock-git-hook that depends on gitlab-grit instead of grit.

    By Administrator on 2013-10-03T13:42:21 (imported from GitLab project)

    By Administrator on 2013-10-03T13:42:21 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: coveralls

    Coverage Status

    Coverage decreased (-0.83%) when pulling e8b6974a on bladealslayer:feature/flowdock_integration into 267e8c73 on gitlabhq:master.

    By Administrator on 2013-10-03T14:21:24 (imported from GitLab project)

    By Administrator on 2013-10-03T14:21:24 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: dzaporozhets

    @bladealslayer thank you

    By Administrator on 2013-10-04T15:00:57 (imported from GitLab project)

    By Administrator on 2013-10-04T15:00:57 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: bladealslayer

    @randx you're welcome!

    By Administrator on 2013-10-04T16:51:28 (imported from GitLab project)

    By Administrator on 2013-10-04T16:51:28 (imported from GitLab)

    • Please register or sign in to reply