Skip to content
Snippets Groups Projects

Better os support init.d

Closed gitlab-qa-bot requested to merge github/fork/neuhalje/better_os_support_init.d into master

Created by: neuhalje

The init.d script fails (at least) on SmartOS, probaply also on other Solaris derivates.

This patch makes the init script work on SmartOS. All changes have been testet in Ubuntu.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Created by: arif-ali

    doesn't work for me on Debian, unless I change the interpreter at the top to #!/bin/bash, See below for my version of OS

    root@gitlab:~# cat /etc/debian_version 
    7.3
    root@gitlab:~# cat /etc/issue
    Debian GNU/Linux 7 \n \l
    

    The error I get is below, if I continue to use /bin/sh as the interpreter

    root@gitlab:~# service gitlab restart
    /etc/init.d/gitlab: 43: [: x: unexpected operator
    /etc/init.d/gitlab: 43: [: xgit: unexpected operator

    By Administrator on 2014-01-20T02:21:02 (imported from GitLab project)

    By Administrator on 2014-01-20T02:21:02 (imported from GitLab)

  • Created by: arif-ali

    :thumbsup:

    actually you should be using = instead of ==, after googling around. That should resolve the problem. == is for bash, and not for POSIX shell

    I have successfully stopped, started, and restarted the gitlab service, using the init.d script

    By Administrator on 2014-01-20T02:28:57 (imported from GitLab project)

    By Administrator on 2014-01-20T02:28:57 (imported from GitLab)

  • Created by: neuhalje

    good catch, updated

    By Administrator on 2014-01-20T07:11:28 (imported from GitLab project)

    By Administrator on 2014-01-20T07:11:28 (imported from GitLab)

  • Created by: neuhalje

    Rebased pull on 6-5-stable because travis claims, that changing init.d script fails some JavaScript unit tests.

    By Administrator on 2014-01-28T07:49:31 (imported from GitLab project)

    By Administrator on 2014-01-28T07:49:31 (imported from GitLab)

Please register or sign in to reply
Loading