Skip to content
Snippets Groups Projects

Small Fixes

Closed gitlab-qa-bot requested to merge github/fork/dubcanada/master into master

Created by: dubcanada

Hey,

I did a few fixes...

  • Made the admin area create a project a duplicate of the client area create a project, and made the admin area create a project function.
  • Removed the taggify javascript from project _new form (it wasn't being called and was causing the rest of the page's javascript to not function)
  • Removed the env -i from the post-receive-hooks file (it was causing problems in Debian 5, Mac OS) tested it on Debian 5, Ubuntu Server 11, Mac OSX without env -i and they are all working. Someone may want to test in some other OS's before merging in this change.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • gitlab-qa-bot
  • gitlab-qa-bot
  • 8 8 # For every branch or tag that was pushed, create a Resque job in redis.
    9 9 pwd=`pwd`
    10 10 reponame=`basename "$pwd" | cut -d. -f1`
    11 env -i redis-cli rpush "resque:queue:post_receive" "{\"class\":\"PostReceive\",\"args\":[\"$reponame\",\"$oldrev\",\"$newrev\",\"$ref\",\"$GL_USER\"]}" > /dev/null 2>&1
    11 redis-cli rpush "resque:queue:post_receive" "{\"class\":\"PostReceive\",\"args\":[\"$reponame\",\"$oldrev\",\"$newrev\",\"$ref\",\"$GL_USER\"]}" > /dev/null 2>&1
  • Created by: dzaporozhets

    @dubcanada i'll merge it if you made a fix

    By Administrator on 2012-04-03T15:46:01 (imported from GitLab project)

    By Administrator on 2012-04-03T15:46:01 (imported from GitLab)

  • Created by: dubcanada

    I returned it to the original method of

    Create a project -> go to project access page.

    Rather then the regular

    Create a project -> go to new project page (with git address and such)

    By Administrator on 2012-04-03T23:28:23 (imported from GitLab project)

    By Administrator on 2012-04-03T23:28:23 (imported from GitLab)

  • gitlab-qa-bot
  • 1 %h1 New project
    1 .project_new_holder
    2 %h3 New Project
    3 %hr
    4 = render 'form'
    5 %div.ajax_loader.hide
    • Created by: dzaporozhets

      form is not ajax so loader is useful here. am i right?

      By Administrator on 2012-04-03T23:30:32 (imported from GitLab project)

      By Administrator on 2012-04-03T23:30:32 (imported from GitLab)

  • gitlab-qa-bot
  • 1 %h1 New project
    1 .project_new_holder
    2 %h3 New Project
    3 %hr
    4 = render 'form'
    5 %div.ajax_loader.hide
    • Created by: dubcanada

      It's literally a copy of the user project creation area. There is no ajax_loader, so I'd say no, and it can probably be removed from the user area too.

      By Administrator on 2012-04-04T03:42:11 (imported from GitLab project)

      By Administrator on 2012-04-04T03:42:11 (imported from GitLab)

  • gitlab-qa-bot
  • 1 %h1 New project
    1 .project_new_holder
    2 %h3 New Project
    3 %hr
    4 = render 'form'
    5 %div.ajax_loader.hide
    • Created by: dzaporozhets

      nope - user area use it. but it is useless here

      By Administrator on 2012-04-04T05:55:23 (imported from GitLab project)

      By Administrator on 2012-04-04T05:55:23 (imported from GitLab)

  • Created by: mikkyhouse

    Btw make sure tests passes

    By Administrator on 2012-04-05T14:10:22 (imported from GitLab project)

    By Administrator on 2012-04-05T14:10:22 (imported from GitLab)

  • Created by: dzaporozhets

    all fixes are out of date.

    except env -i - but I'm not sure about it. Its should be another PR.

    By Administrator on 2012-04-25T09:45:35 (imported from GitLab project)

    By Administrator on 2012-04-25T09:45:35 (imported from GitLab)

  • Please register or sign in to reply
    Loading