Skip to content
Snippets Groups Projects

Mobile UI improvements

Merged Mobile UI improvements
github/fork/dblessing/mobile_ui into master
Merged gitlab-qa-bot requested to merge github/fork/dblessing/mobile_ui into master

Created by: dblessing

This PR fixes some things in the mobile UI. The biggest fix is for public pages. Previously, on public pages the navigation was expanded by default and the sign in button took up lots of space at the top (especially after we add the collapsed navigation icon). See screenshots below.

Tested on a handful of popular mobile devices - iPhone 5, Galaxy S4, Google Nexus 4. All appear as expected after the changes.

Before: Sign in button causes top bar to be taller than expected. Also, nav has no toggle and is always visible. mobile-redux-1

After: (Note: The light blue highlight around the nav icon is because I used Chrome emulator to take these shots and my mouse click "selected" the icon. It does not actually show on real mobile device. mobile-redux-2 After adding the nav icon, the spinner would appear right on top of the spinner. Now, it moves just to the left, but doesn't affect long project names, as shown below. mobile-redux-3

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: dzaporozhets

    thanks

    By Administrator on 2014-03-24T07:49:28 (imported from GitLab project)

    By Administrator on 2014-03-24T07:49:28 (imported from GitLab)

Please register or sign in to reply