Fixed external links to non-JIRA issue trackers
Created by: tyler-sommer
External issue links (like #123 (closed)) to Redmine stopped working, this fixes what seems to be the cause.
Originally the check was if project.used_default_issues_tracker? || !external_issues_tracker_enabled? which was necessary because jira is external, and we need special handling for jira. However, this broke linking for other issue trackers like redmine.
This PR modifies the conditional slightly to still allow external trackers that are not jira to link
Merge request reports
Activity
Created by: TeatroIO
I've prepared a stage. Click to open.
By Administrator on 2014-07-01T20:16:08 (imported from GitLab project)
By Administrator on 2014-07-01T20:16:08 (imported from GitLab)
181 181 end 182 182 183 183 def reference_issue(identifier, project = @project) 184 if project.used_default_issues_tracker? || !external_issues_tracker_enabled? 184 if project.used_default_issues_tracker? || 185 (external_issues_tracker_enabled? && project.issues_tracker != "jira") 185 186 if project.issue_exists? identifier 181 181 end 182 182 183 183 def reference_issue(identifier, project = @project) 184 if project.used_default_issues_tracker? || !external_issues_tracker_enabled? 184 if project.used_default_issues_tracker? || 181 181 end 182 182 183 183 def reference_issue(identifier, project = @project) 184 if project.used_default_issues_tracker? || !external_issues_tracker_enabled? 184 if project.used_default_issues_tracker? || 185 (external_issues_tracker_enabled? && project.issues_tracker != "jira") 181 181 end 182 182 183 183 def reference_issue(identifier, project = @project) 184 if project.used_default_issues_tracker? || !external_issues_tracker_enabled? 184 if project.used_default_issues_tracker? || Created by: zzet
@tyler-sommer this PR duplicate of https://github.com/gitlabhq/gitlabhq/pull/7147 ?
By Administrator on 2014-07-02T11:43:42 (imported from GitLab project)
By Administrator on 2014-07-02T11:43:42 (imported from GitLab)
Created by: tyler-sommer
@zzet Yes it appears so. Your PR #7147 is also a much more complete solution fixing the empty issue title in the link. I'll close this in favor of yours, thanks!
By Administrator on 2014-07-23T16:06:01 (imported from GitLab project)
By Administrator on 2014-07-23T16:06:01 (imported from GitLab)
