Skip to content
Snippets Groups Projects

Added metadata to Issue

Closed gitlab-qa-bot requested to merge github/fork/rightshift/master into master

Created by: joel-rightshift

We needed a field on Issue that could hold arbitrary data. To enable this, we added a metadata field. The change itself it rather simple

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Unable to load the diff
  • Created by: houndci-bot

    Line is too long. [112/80]

    By Administrator on 2014-09-25T14:48:23 (imported from GitLab project)

    By Administrator on 2014-09-25T14:48:23 (imported from GitLab)

  • gitlab-qa-bot
  • Unable to load the diff
    • Created by: houndci-bot

      Line is too long. [98/80]

      By Administrator on 2014-09-25T14:48:23 (imported from GitLab project)

      By Administrator on 2014-09-25T14:48:23 (imported from GitLab)

  • Created by: jvanbaarsen

    @joel-rightshift I'm not sure about this one, since this would add other behaviour to the API then whats possible from the web-interface. I think @dosire or @randx have to decide on this one.

    By Administrator on 2014-07-25T20:29:09 (imported from GitLab project)

    By Administrator on 2014-07-25T20:29:09 (imported from GitLab)

  • Created by: dosire

    I'm leaving this to @randx

    By Administrator on 2014-07-27T16:05:33 (imported from GitLab project)

    By Administrator on 2014-07-27T16:05:33 (imported from GitLab)

  • Created by: jvanbaarsen

    @randx What do you think about this?

    By Administrator on 2014-08-16T09:39:35 (imported from GitLab project)

    By Administrator on 2014-08-16T09:39:35 (imported from GitLab)

  • gitlab-qa-bot
  • 129 133 put ":id/issues/:issue_id" do
    130 134 issue = user_project.issues.find(params[:issue_id])
    131 135 authorize! :modify_issue, issue
    136 <<<<<<< HEAD
    • Created by: houndci-bot

      unexpected token tLSHFT

      By Administrator on 2014-09-25T14:48:25 (imported from GitLab project)

      By Administrator on 2014-09-25T14:48:25 (imported from GitLab)

  • gitlab-qa-bot
  • 129 133 put ":id/issues/:issue_id" do
    130 134 issue = user_project.issues.find(params[:issue_id])
    131 135 authorize! :modify_issue, issue
    136 <<<<<<< HEAD
    137
    138 attrs = attributes_for_keys [:title, :description, :assignee_id, :milestone_id, :state_event, :metadata]
    139 attrs[:label_list] = params[:labels] if params[:labels].present?
    140 =======
    132 141 attrs = attributes_for_keys [:title, :description, :assignee_id, :milestone_id, :state_event]
    133 142
    134 143 # Validate label names in advance
    135 144 if (errors = validate_label_params(params)).any?
    136 145 render_api_error!({ labels: errors }, 400)
    137 146 end
    147 >>>>>>> upstream/master
    • Created by: houndci-bot

      unexpected token tRSHFT

      By Administrator on 2014-09-25T14:48:26 (imported from GitLab project)

      By Administrator on 2014-09-25T14:48:26 (imported from GitLab)

  • gitlab-qa-bot
  • 129 133 put ":id/issues/:issue_id" do
    130 134 issue = user_project.issues.find(params[:issue_id])
    131 135 authorize! :modify_issue, issue
    136 <<<<<<< HEAD
    137
    138 attrs = attributes_for_keys [:title, :description, :assignee_id, :milestone_id, :state_event, :metadata]
    139 attrs[:label_list] = params[:labels] if params[:labels].present?
    140 =======
    • Created by: houndci-bot

      unexpected token tEQQ

      By Administrator on 2014-09-25T14:48:26 (imported from GitLab project)

      By Administrator on 2014-09-25T14:48:26 (imported from GitLab)

  • Created by: jvanbaarsen

    @joel-rightshift Looks like you left some merge conflict stuff in there, can you please fix? ping @randx What do you think?

    By Administrator on 2014-10-06T06:04:42 (imported from GitLab project)

    By Administrator on 2014-10-06T06:04:42 (imported from GitLab)

  • Created by: dblessing

    @joel-rightshift Do you still have time to work on this?

    By Administrator on 2014-11-11T14:24:42 (imported from GitLab project)

    By Administrator on 2014-11-11T14:24:42 (imported from GitLab)

  • Created by: dblessing

    This merge request has been closed because a request for more information has not been reacted to for more than 2 weeks. If you respond and conform to the merge request guidelines in our contributing guidelines we will reopen this merge request.

    By Administrator on 2014-12-20T14:58:24 (imported from GitLab project)

    By Administrator on 2014-12-20T14:58:24 (imported from GitLab)

  • Please register or sign in to reply
    Loading