Skip to content
Snippets Groups Projects

Add tag push events to project hook api

Merged gitlab-qa-bot requested to merge github/fork/Bugagazavr/hook_tag_push_events into master

Created by: Bugagazavr

What does this MR do? Allow add push tag event via API Are there points in the code the reviewer needs to double check? No Why was this MR needed? Catch tag push event on external services to build release

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Unable to load the diff
  • Created by: houndci-bot

    Line is too long. [114/80]

    By Administrator on 2014-10-03T06:26:12 (imported from GitLab project)

    By Administrator on 2014-10-03T06:26:12 (imported from GitLab)

  • gitlab-qa-bot
  • 38 38 # POST /projects/:id/hooks
    39 39 post ":id/hooks" do
    40 40 required_attributes! [:url]
    41 attrs = attributes_for_keys [:url, :push_events, :issues_events, :merge_requests_events]
    41 attrs = attributes_for_keys [
    • Created by: houndci-bot

      Line is too long. [114/80]

      By Administrator on 2014-10-03T06:26:12 (imported from GitLab project)

      By Administrator on 2014-10-03T06:26:12 (imported from GitLab)

  • gitlab-qa-bot
  • 30 30 end
    31 31
    32 32 class ProjectHook < Hook
    33 expose :project_id, :push_events, :issues_events, :merge_requests_events
    33 expose :project_id, :push_events
    • Created by: houndci-bot

      Line is too long. [96/80]

      By Administrator on 2014-10-03T06:26:12 (imported from GitLab project)

      By Administrator on 2014-10-03T06:26:12 (imported from GitLab)

  • gitlab-qa-bot
  • 30 30 end
    31 31
    32 32 class ProjectHook < Hook
    33 expose :project_id, :push_events, :issues_events, :merge_requests_events
    33 expose :project_id, :push_events
    34 expose :issues_events, :merge_requests_events, :tag_push_events
    • Created by: houndci-bot

      Line is too long. [83/80]

      By Administrator on 2014-10-03T06:26:12 (imported from GitLab project)

      By Administrator on 2014-10-03T06:26:12 (imported from GitLab)

  • gitlab-qa-bot
  • 62 68 put ":id/hooks/:hook_id" do
    63 69 @hook = user_project.hooks.find(params[:hook_id])
    64 70 required_attributes! [:url]
    65 attrs = attributes_for_keys [:url, :push_events, :issues_events, :merge_requests_events]
    71 attrs = attributes_for_keys [
    72 :url,
    73 :push_events,
    74 :issues_events,
    75 :merge_requests_events,
    • Created by: houndci-bot

      Trailing whitespace detected.

      By Administrator on 2014-10-03T06:26:12 (imported from GitLab project)

      By Administrator on 2014-10-03T06:26:12 (imported from GitLab)

  • gitlab-qa-bot
  • 62 68 put ":id/hooks/:hook_id" do
    63 69 @hook = user_project.hooks.find(params[:hook_id])
    64 70 required_attributes! [:url]
    65 attrs = attributes_for_keys [:url, :push_events, :issues_events, :merge_requests_events]
    71 attrs = attributes_for_keys [
    72 :url,
    73 :push_events,
    • Created by: houndci-bot

      Trailing whitespace detected.

      By Administrator on 2014-10-03T06:26:12 (imported from GitLab project)

      By Administrator on 2014-10-03T06:26:12 (imported from GitLab)

  • gitlab-qa-bot
  • 62 68 put ":id/hooks/:hook_id" do
    63 69 @hook = user_project.hooks.find(params[:hook_id])
    64 70 required_attributes! [:url]
    65 attrs = attributes_for_keys [:url, :push_events, :issues_events, :merge_requests_events]
    71 attrs = attributes_for_keys [
    72 :url,
    73 :push_events,
    74 :issues_events,
    • Created by: houndci-bot

      Trailing whitespace detected.

      By Administrator on 2014-10-03T06:26:12 (imported from GitLab project)

      By Administrator on 2014-10-03T06:26:12 (imported from GitLab)

  • gitlab-qa-bot
  • 62 68 put ":id/hooks/:hook_id" do
    63 69 @hook = user_project.hooks.find(params[:hook_id])
    64 70 required_attributes! [:url]
    65 attrs = attributes_for_keys [:url, :push_events, :issues_events, :merge_requests_events]
    71 attrs = attributes_for_keys [
    72 :url,
    • Created by: houndci-bot

      Trailing whitespace detected.

      By Administrator on 2014-10-03T06:26:12 (imported from GitLab project)

      By Administrator on 2014-10-03T06:26:12 (imported from GitLab)

  • gitlab-qa-bot
  • 38 38 # POST /projects/:id/hooks
    39 39 post ":id/hooks" do
    40 40 required_attributes! [:url]
    41 attrs = attributes_for_keys [:url, :push_events, :issues_events, :merge_requests_events]
    41 attrs = attributes_for_keys [
    42 :url,
    43 :push_events,
    44 :issues_events,
    45 :merge_requests_events,
    • Created by: houndci-bot

      Trailing whitespace detected.

      By Administrator on 2014-10-03T06:26:12 (imported from GitLab project)

      By Administrator on 2014-10-03T06:26:12 (imported from GitLab)

  • gitlab-qa-bot
  • 38 38 # POST /projects/:id/hooks
    39 39 post ":id/hooks" do
    40 40 required_attributes! [:url]
    41 attrs = attributes_for_keys [:url, :push_events, :issues_events, :merge_requests_events]
    41 attrs = attributes_for_keys [
    42 :url,
    43 :push_events,
    44 :issues_events,
    • Created by: houndci-bot

      Trailing whitespace detected.

      By Administrator on 2014-10-03T06:26:12 (imported from GitLab project)

      By Administrator on 2014-10-03T06:26:12 (imported from GitLab)

  • gitlab-qa-bot
  • 38 38 # POST /projects/:id/hooks
    39 39 post ":id/hooks" do
    40 40 required_attributes! [:url]
    41 attrs = attributes_for_keys [:url, :push_events, :issues_events, :merge_requests_events]
    41 attrs = attributes_for_keys [
    42 :url,
    43 :push_events,
    • Created by: houndci-bot

      Trailing whitespace detected.

      By Administrator on 2014-10-03T06:26:12 (imported from GitLab project)

      By Administrator on 2014-10-03T06:26:12 (imported from GitLab)

  • gitlab-qa-bot
  • 38 38 # POST /projects/:id/hooks
    39 39 post ":id/hooks" do
    40 40 required_attributes! [:url]
    41 attrs = attributes_for_keys [:url, :push_events, :issues_events, :merge_requests_events]
    41 attrs = attributes_for_keys [
    42 :url,
    • Created by: houndci-bot

      Trailing whitespace detected.

      By Administrator on 2014-10-03T06:26:12 (imported from GitLab project)

      By Administrator on 2014-10-03T06:26:12 (imported from GitLab)

  • gitlab-qa-bot
  • 30 30 end
    31 31
    32 32 class ProjectHook < Hook
    33 expose :project_id, :push_events, :issues_events, :merge_requests_events
    33 expose :project_id, :push_events
    • Created by: houndci-bot

      Trailing whitespace detected.

      By Administrator on 2014-10-03T06:26:12 (imported from GitLab project)

      By Administrator on 2014-10-03T06:26:12 (imported from GitLab)

  • Created by: Razer6

    @bugagazavr Looks good! Can you rebase to make it ready to :ship: ?

    By Administrator on 2014-10-03T05:46:44 (imported from GitLab project)

    By Administrator on 2014-10-03T05:46:44 (imported from GitLab)

  • Created by: Bugagazavr

    @razer6 rdy

    By Administrator on 2014-10-03T06:54:23 (imported from GitLab project)

    By Administrator on 2014-10-03T06:54:23 (imported from GitLab)

  • Created by: Razer6

    :thumbsup:

    By Administrator on 2014-10-03T07:09:15 (imported from GitLab project)

    By Administrator on 2014-10-03T07:09:15 (imported from GitLab)

  • Please register or sign in to reply
    Loading