Factor zen mode.
Created by: cirosantilli
Almost the same code was on 3 different places.
Minor UI change: both new issue and merge request description textarea are now the same size. They were different sizes, so I picked an intermediate new size. The change is almost unnoticeable.
The pages that could be affected are: new / edit issue and merge request, diff notes and comments.
This continues the move for form DRYness as in https://github.com/gitlabhq/gitlabhq/pull/7678
cc. @razer6 if you get the time please check that I didn't break the feature =) A good indicator of non-DRYness are strings shown on the UI: when I saw that there were two occurrences of "Edit in fullscreen", I immediately git grep -C2 'Edit in
and found this opportunity for DRYing.
Merge request reports
Activity
Created by: TeatroIO
I've prepared a stage. Click to open.
By Administrator on 2014-09-20T13:37:09 (imported from GitLab project)
By Administrator on 2014-09-20T13:37:09 (imported from GitLab)
Created by: Razer6
I checked out the PR locally and tested it. Looks good
Since this is directly related to a new introduced feature in 7.3 I merge this.By Administrator on 2014-09-20T15:09:17 (imported from GitLab project)
By Administrator on 2014-09-20T15:09:17 (imported from GitLab)
Created by: Razer6
@cirosantilli Hey, I just saw an minor issue for the
Edit in Fullscreen
label. This is not related to this PR. If the text area for a not has focus (blue glow), hovering overEdit in Fullscreen
overwrites the glow.I tried to fix this, but do not see the error. Only the opacity is changed when hovering. Maybe you have a glue?
By Administrator on 2014-09-20T16:14:46 (imported from GitLab project)
By Administrator on 2014-09-20T16:14:46 (imported from GitLab)