Skip to content
Snippets Groups Projects

Factor zen mode.

Merged gitlab-qa-bot requested to merge github/fork/cirosantilli/dry-zen-view into master

Created by: cirosantilli

Almost the same code was on 3 different places.

Minor UI change: both new issue and merge request description textarea are now the same size. They were different sizes, so I picked an intermediate new size. The change is almost unnoticeable.

The pages that could be affected are: new / edit issue and merge request, diff notes and comments.

This continues the move for form DRYness as in https://github.com/gitlabhq/gitlabhq/pull/7678

cc. @razer6 if you get the time please check that I didn't break the feature =) A good indicator of non-DRYness are strings shown on the UI: when I saw that there were two occurrences of "Edit in fullscreen", I immediately git grep -C2 'Edit in and found this opportunity for DRYing.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Created by: TeatroIO

    I've prepared a stage. Click to open.

    By Administrator on 2014-09-20T13:37:09 (imported from GitLab project)

    By Administrator on 2014-09-20T13:37:09 (imported from GitLab)

  • Created by: Razer6

    I'll test the PR as soon I've my dev setup working again. HDD crash :facepunch:

    By Administrator on 2014-09-20T14:02:15 (imported from GitLab project)

    By Administrator on 2014-09-20T14:02:15 (imported from GitLab)

  • Created by: cirosantilli

    Ouch :hospital:

    By Administrator on 2014-09-20T14:00:43 (imported from GitLab project)

    By Administrator on 2014-09-20T14:00:43 (imported from GitLab)

  • Created by: Razer6

    I checked out the PR locally and tested it. Looks good :thumbsup: Since this is directly related to a new introduced feature in 7.3 I merge this.

    By Administrator on 2014-09-20T15:09:17 (imported from GitLab project)

    By Administrator on 2014-09-20T15:09:17 (imported from GitLab)

  • Created by: Razer6

    @cirosantilli Hey, I just saw an minor issue for the Edit in Fullscreen label. This is not related to this PR. If the text area for a not has focus (blue glow), hovering over Edit in Fullscreen overwrites the glow.

    screenshot 2014-09-20 18 10 26

    I tried to fix this, but do not see the error. Only the opacity is changed when hovering. Maybe you have a glue?

    By Administrator on 2014-09-20T16:14:46 (imported from GitLab project)

    By Administrator on 2014-09-20T16:14:46 (imported from GitLab)

  • Created by: cirosantilli

    Hmm I haven't been able to reproduce on Firefox 32 Chromium 37. What view and browser are you on?

    By Administrator on 2014-09-20T16:19:52 (imported from GitLab project)

    By Administrator on 2014-09-20T16:19:52 (imported from GitLab)

  • Created by: Razer6

    Hmm, Chrome 37.0.2062.122 on OSX also doesn't show this issue. I'm on Safari 7.1 on OSX 10.9.5.

    By Administrator on 2014-09-20T16:25:07 (imported from GitLab project)

    By Administrator on 2014-09-20T16:25:07 (imported from GitLab)

Please register or sign in to reply
Loading