Fix missing flash on file edit error from web UI.

Created by: cirosantilli

These bugs were introduced by myself at https://github.com/gitlabhq/gitlabhq/pull/7807

The fact that the refactoring lead to bugs means we should add more tests for those error cases =)

Also removed the out[:error] = '' which never happens: every place of the app first checks for success.

Added tests that would have prevented me from generating this bug.

Needs to be double checked

One of the tests is @wip as explained on the source: I can't get it working no matter what. Still it shows the behavior and does an initial step to point to the cause of the problem.

This seems to be an unrelated bug in GitLab, so I've opened a separate report at: https://github.com/gitlabhq/gitlabhq/issues/7950

Update

This was partially fixed after this PR at: https://github.com/gitlabhq/gitlabhq/commit/184e0f , but only partially since the blob destroy, edit and API messages were not fixed, only the new blob case.

Created by: TeatroIO

I've prepared a stage. Click to open.

By Administrator on 2014-09-25T15:01:17 (imported from GitLab project)

By Administrator on 2014-09-25T15:01:17 (imported from GitLab)

Created by: cirosantilli

here

By Administrator on 2014-10-13T18:55:31 (imported from GitLab project)

By Administrator on 2014-10-13T18:55:31 (imported from GitLab)

Created by: Razer6

@cirosantilli Could you rebase?

By Administrator on 2014-10-13T16:34:53 (imported from GitLab project)

By Administrator on 2014-10-13T16:34:53 (imported from GitLab)

Created by: cirosantilli

@razer6 done.

By Administrator on 2014-10-13T20:35:06 (imported from GitLab project)

By Administrator on 2014-10-13T20:35:06 (imported from GitLab)

Created by: Razer6

@randx @maxlazio This PR should still go to 7.4, because it's fixing a regression introduced in this release.

By Administrator on 2014-10-18T07:34:26 (imported from GitLab project)

By Administrator on 2014-10-18T07:34:26 (imported from GitLab)

Created by: cirosantilli

This was partially fixed at: https://github.com/gitlabhq/gitlabhq/commit/184e0f , but only partially since the blob edit, destroy and API messages were not fixed.

By Administrator on 2014-10-18T07:53:02 (imported from GitLab project)

By Administrator on 2014-10-18T07:53:02 (imported from GitLab)

Created by: dosire

@cirosantilli Thanks for adding regression tests Ciro!

By Administrator on 2014-10-19T13:10:16 (imported from GitLab project)

By Administrator on 2014-10-19T13:10:16 (imported from GitLab)

Created by: cirosantilli

I want this baby to work!

By Administrator on 2014-10-19T13:11:37 (imported from GitLab project)

By Administrator on 2014-10-19T13:11:37 (imported from GitLab)

Created by: dzaporozhets

Thanks!

By Administrator on 2014-10-20T09:52:29 (imported from GitLab project)

By Administrator on 2014-10-20T09:52:29 (imported from GitLab)