Skip to content

Change always passing visible false tests.

gitlab-qa-bot requested to merge github/fork/cirosantilli/visible-false into master

Created by: cirosantilli

Many usages of visible: false are wrong since visible: false matches both visible and invisible elements: http://rubydoc.info/github/jnicklas/capybara/master/Capybara/Node/Finders#all-instance_method

The correct way to check that an element is present but not visible is:

expect(find(...)).not_to be_visible

The two "I can't preview without text" scenarios are not true anymore: now you can preview without text, so I removed then. They only passed because of the misuse. Screenshot:

screenshot from 2014-09-30 15 56 00 js not preview visible without text

'I should see add a diff comment button' is simply wrong: it should be visible: true instead of visible: false.

Merge request reports