Change always passing visible false tests.
Created by: cirosantilli
Many usages of visible: false
are wrong since visible: false
matches both visible and invisible elements: http://rubydoc.info/github/jnicklas/capybara/master/Capybara/Node/Finders#all-instance_method
The correct way to check that an element is present but not visible is:
expect(find(...)).not_to be_visible
The two "I can't preview without text" scenarios are not true anymore: now you can preview without text, so I removed then. They only passed because of the misuse. Screenshot:
'I should see add a diff comment button'
is simply wrong: it should be visible: true
instead of visible: false
.
Merge request reports
Activity
Created by: TeatroIO
I've prepared a stage. Click to open.
By Administrator on 2014-09-29T22:00:23 (imported from GitLab project)
By Administrator on 2014-09-29T22:00:23 (imported from GitLab)
Created by: jvanbaarsen
@cirosantilli Can you make this mergeable again?
By Administrator on 2014-12-23T15:47:29 (imported from GitLab project)
By Administrator on 2014-12-23T15:47:29 (imported from GitLab)
Created by: cirosantilli
@jvanbaarsen updated.
By Administrator on 2015-01-01T23:42:15 (imported from GitLab project)
By Administrator on 2015-01-01T23:42:15 (imported from GitLab)