Skip to content
Snippets Groups Projects

Change always passing visible false tests.

Merged gitlab-qa-bot requested to merge github/fork/cirosantilli/visible-false into master

Created by: cirosantilli

Many usages of visible: false are wrong since visible: false matches both visible and invisible elements: http://rubydoc.info/github/jnicklas/capybara/master/Capybara/Node/Finders#all-instance_method

The correct way to check that an element is present but not visible is:

expect(find(...)).not_to be_visible

The two "I can't preview without text" scenarios are not true anymore: now you can preview without text, so I removed then. They only passed because of the misuse. Screenshot:

screenshot from 2014-09-30 15 56 00 js not preview visible without text

'I should see add a diff comment button' is simply wrong: it should be visible: true instead of visible: false.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Unable to load the diff
  • Created by: houndci-bot

    Prefer single-quoted strings when you don't need string interpolation or special symbols.

    By Administrator on 2015-01-01T23:20:24 (imported from GitLab project)

    By Administrator on 2015-01-01T23:20:24 (imported from GitLab)

  • gitlab-qa-bot
  • Unable to load the diff
    • Created by: houndci-bot

      Prefer single-quoted strings when you don't need string interpolation or special symbols.

      By Administrator on 2015-01-01T23:20:24 (imported from GitLab project)

      By Administrator on 2015-01-01T23:20:24 (imported from GitLab)

  • gitlab-qa-bot
  • Unable to load the diff
    • Created by: houndci-bot

      Prefer single-quoted strings when you don't need string interpolation or special symbols.

      By Administrator on 2015-01-01T23:20:24 (imported from GitLab project)

      By Administrator on 2015-01-01T23:20:24 (imported from GitLab)

  • gitlab-qa-bot
  • Unable to load the diff
    • Created by: houndci-bot

      Prefer single-quoted strings when you don't need string interpolation or special symbols.

      By Administrator on 2015-01-01T23:20:24 (imported from GitLab project)

      By Administrator on 2015-01-01T23:20:24 (imported from GitLab)

  • gitlab-qa-bot
  • Unable to load the diff
    • Created by: houndci-bot

      Prefer single-quoted strings when you don't need string interpolation or special symbols.

      By Administrator on 2015-01-01T23:20:24 (imported from GitLab project)

      By Administrator on 2015-01-01T23:20:24 (imported from GitLab)

  • gitlab-qa-bot
  • Unable to load the diff
    • Created by: houndci-bot

      Prefer single-quoted strings when you don't need string interpolation or special symbols.

      By Administrator on 2015-01-01T23:20:24 (imported from GitLab project)

      By Administrator on 2015-01-01T23:20:24 (imported from GitLab)

  • gitlab-qa-bot
  • Unable to load the diff
    • Created by: houndci-bot

      Prefer single-quoted strings when you don't need string interpolation or special symbols.

      By Administrator on 2015-01-01T23:20:24 (imported from GitLab project)

      By Administrator on 2015-01-01T23:20:24 (imported from GitLab)

  • Created by: jvanbaarsen

    @cirosantilli Can you make this mergeable again?

    By Administrator on 2014-12-23T15:47:29 (imported from GitLab project)

    By Administrator on 2014-12-23T15:47:29 (imported from GitLab)

  • Created by: cirosantilli

    @jvanbaarsen updated.

    By Administrator on 2015-01-01T23:42:15 (imported from GitLab project)

    By Administrator on 2015-01-01T23:42:15 (imported from GitLab)

  • Please register or sign in to reply
    Loading