Skip to content
Snippets Groups Projects

Fix downcase for Non-ASCII strings in ldap extern_uid

Fix downcase for Non-ASCII strings in ldap extern_uid
github/fork/ugurlu/ldap_unicode_lowercase_fix into master
Closed gitlab-qa-bot requested to merge github/fork/ugurlu/ldap_unicode_lowercase_fix into master

Created by: ugurlu

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
lib/gitlab/ldap/user.rb
52 52
53 53 def find_by_uid(uid)
54 54 # LDAP distinguished name is case-insensitive
55 model.where("provider = ? and lower(extern_uid) = ?", provider, uid.downcase).last
55 model.where("provider = ? and lower(extern_uid) = ?", provider, uid.mb_chars.downcase).last
  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: houndci-bot

    Line is too long. [101/80]
    Prefer single-quoted strings when you don't need string interpolation or special symbols.

    By Administrator on 2014-10-02T13:27:13 (imported from GitLab project)

    By Administrator on 2014-10-02T13:27:13 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: jvanbaarsen

    This merge request has been closed because a request for more information has not been reacted to for more than 2 weeks. If you respond and conform to the merge request guidelines in our contributing guidelines we will reopen this merge request.

    By Administrator on 2014-12-14T10:26:51 (imported from GitLab project)

    By Administrator on 2014-12-14T10:26:51 (imported from GitLab)

    • Please register or sign in to reply