Skip to content
Snippets Groups Projects

Fixed link to config/database.yml.mysql file

Closed gitlab-qa-bot requested to merge github/fork/raiseandfall/patch-1 into master

Created by: raiseandfall

Link was broken and pointed to 404 error.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Created by: TeatroIO

    I've prepared a stage. Click to open.

    By Administrator on 2014-11-12T19:05:25 (imported from GitLab project)

    By Administrator on 2014-11-12T19:05:25 (imported from GitLab)

  • Created by: cirosantilli

    :thumbsdown: I'd rather have:

    • paths without the domain which could work both on gitlab and github, e.g. something like /config/database.yml.mysql

      If it's not possible to have one that works on both because of Md incompatibility, we should at least use one that works on gitlab so that local installs can see the doc properly.

    • non fixed version. We have to show the path to the config file of the current version

    Also, the canonical source is at gitlab.com, so if we do use a link with domain name, it should point to gitlab.

    By Administrator on 2014-11-13T08:57:58 (imported from GitLab project)

    By Administrator on 2014-11-13T08:57:58 (imported from GitLab)

  • Created by: raiseandfall

    Good point. What about using a relative link ( ../../config/database.yml.mysql ) ? It will then point to the current version.

    By Administrator on 2014-11-13T18:28:52 (imported from GitLab project)

    By Administrator on 2014-11-13T18:28:52 (imported from GitLab)

  • Created by: cirosantilli

    Yup, if that is working, it would be good, or even better /config/database.yml.mysql if it works. I remember there was something like that breaking though so you'd have to test.

    Maybe: https://github.com/gitlabhq/gitlabhq/issues/8134

    By Administrator on 2014-11-13T19:36:26 (imported from GitLab project)

    By Administrator on 2014-11-13T19:36:26 (imported from GitLab)

  • Created by: jvanbaarsen

    This merge request has been closed because a request for more information has not been reacted to for more than 2 weeks. If you respond and conform to the merge request guidelines in our contributing guidelines we will reopen this merge request.

    By Administrator on 2015-01-18T18:04:41 (imported from GitLab project)

    By Administrator on 2015-01-18T18:04:41 (imported from GitLab)

Please register or sign in to reply
Loading