Skip to content
Snippets Groups Projects

Fix many encoding problems

Merged gitlab-qa-bot requested to merge github/fork/brodock/fix_encoding into master

Created by: brodock

I've appended bug fixes for #725 (closed), #782 (closed), #648 (closed), #782 (closed) with a better solution then force_encoding to UTF-8 as it will not fix every case. A proper reading of Yehuda Katz's article about 1.9 encoding is a must to fully understand the problem: http://yehudakatz.com/2010/05/05/ruby-1-9-encodings-a-primer-and-the-solution-for-rails/.

This also fixes a unreported problem with plain/text blobs being sent without charset being informed on HTTP HEADER.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Created by: zx1986

    @brodock WOW! AWESOME JOB!

    By Administrator on 2012-05-27T03:29:27 (imported from GitLab project)

    By Administrator on 2012-05-27T03:29:27 (imported from GitLab)

  • Created by: dzaporozhets

    like it, merged

    By Administrator on 2012-05-27T09:21:24 (imported from GitLab project)

    By Administrator on 2012-05-27T09:21:24 (imported from GitLab)

  • Created by: tul

    thanks @brodock :)

    my #725 (closed) issues were fixed by the 2.5 update, but I suspect your fix is more 'correct'!

    By Administrator on 2012-05-28T08:48:52 (imported from GitLab project)

    By Administrator on 2012-05-28T08:48:52 (imported from GitLab)

  • Created by: zzjin

    update to 2.5 but still have encoding error in network/graph

    ArgumentError (redundant UTF-8 sequence): lib/graph_commit.rb:18:in `to_graph'

    By Administrator on 2012-05-28T09:24:34 (imported from GitLab project)

    By Administrator on 2012-05-28T09:24:34 (imported from GitLab)

Please register or sign in to reply
Loading