Skip to content

Stable

Matthias Käppler requested to merge github/fork/zuci42/stable into master

Created by: zuci42

Hi

Recently I have found out strange gitlab behaviour, on push failure rails worker stucked at deleted temporary folder

adding more projects after that ends in:

fatal: Could not get current working directory: No such file or directory

looking for cwd in proc shows this:

gitlab gitlab 0 Nov 9 15:43 /proc/6307/cwd -> /home/www-data/projects/gitlab..ru/tmp/gitlabhq-gitolite-1352461514/gitolite (deleted) gitlab gitlab 0 Nov 9 15:43 /proc/6310/cwd -> /home/www-data/projects/gitlab..ru/tmp/gitlabhq-gitolite-1352461704/gitolite (deleted)

some time ago:

e8f39a0a (randx 2012-09-07 20:43:51 +0300 197)

was commited chdir only upon succesfsul push that's look strange for me as signle push failure shouldn't lead to system nonoperability.

my suggestion is to change cwd to Rails.root anytime before gitolite-admin temporary directories cleanup

Merge request reports

Loading