Skip to content

Hotfix note mail with notification

Matthias Käppler requested to merge github/fork/huacnlee/hotfix/note_mail_with_notification into 8-3-stable

Created by: huacnlee

Today I found some error log:

Email can not be processed: undefined method `note_note_email' for Notify:Class

When I reply a Issue comment by Email reply, It will create a new Note into database but not relation with the Issue.

In current 8-3-stable (even in master version), Emails::Notes invoked SentNotification.record, that will store a bad noteable value.

See this file: https://github.com/gitlabhq/gitlabhq/blob/8-0-stable/app/mailers/emails/notes.rb#L46

@yorickpeterse

Merge request reports