Skip to content

Broken URL in long commit message

Matthias Käppler requested to merge github/fork/fpgentil/broken-url into master

Created by: fpgentil

As mentioned here #9388 (closed), when a commit contains a long commit message including a URL, after truncating to be shown in dashboard, the URL is broken, therefore, causing a broken link.

Commit example bildschirmfoto 2015-10-16 um 17 17 59

Broken URL bildschirmfoto 2015-10-16 um 17 19 42 bildschirmfoto 2015-10-16 um 17 19 34

Fixed URL bildschirmfoto 2015-10-16 um 17 20 30

My first idea was extract the full URLs in the events_helper.rb and send them (if more then one) to gfm. I'm still now sure if this is a good approach. I'd like some feedbacks before writing some tests, do you think it's worth to keep the URL or simply remove the <a href=""></a> if the URL is not valid?

Thanks in advance 😄

Merge request reports