Skip to content

Fix bug with rendering changing images in commits

Matthias Käppler requested to merge github/fork/Nullreff/image-diff into master

Created by: Nullreff

When viewing the diff for a changed image file, two bugs occur:

  • Both the 'before' and 'after' images link to the 'after' commit
  • Visiting the link for either image will cause a error

The first is caused by both image links referencing @commit.id rather than @commit.parent_id. The second is caused by the use of project_tree_path which is used for creating links to directories in the git file tree. project_blob_path (which links to files) should be used instead.

Live example click on the images for blueprint_add.png or blueprint_delete.png.

Merge request reports