Skip to content

Improve file icons rendering on tree

Matthias Käppler requested to merge github/fork/soullivaneuh/file-type into master

Created by: soullivaneuh

TODO list:

  • Make decision about icons choose and methods
  • Integrate new icons to tree index view
  • Integrate new icons to tree file show view
  • Write some test about the different icon rendering
  • Update CHANGELOG

Referred to this request, I did some improvements to file icons rendering.

This mean:

So, from the actual design: gitlab_icons_before

I made this: gitlab_icons_after

The share link sounds good for me, but I don't really like the file-code for binary, to tiny to differentiate and note really appropriate...

So I tried with fa-terminal: gitlab_icons_terminal

Well, not really better. So what about fa-cog ? gitlab_icons_cog

In my opinion, I think fa-cog is the better rendering for binaries. But, well, doesn't really look like a file...

Two possible options:

  • Use fa-stack method for custom file icon as explained here, but I have to change the template code for this and this will force you to use file-icon in any way.
  • Integrate Github octicons which has binary and symlink icons.

If we choose the second option, I have to check before if Octicons and Font Awesome libraries can work together without any conflict. Furthermore, I think we will have to add some contributing rules indicate that the FA icons must be user in priority!

I need your feedback to continue this work. If you have another ideas/solutions, please tell me more! 👍 Tell me if you think I forgot something on the todo list. 😉

Waiting yours reviews.

Merge request reports

Loading