Skip to content

Web edit and HTTPS push work if multiple Rubies installed v3 [can be updated]

Matthias Käppler requested to merge github/fork/cirosantilli/multiple-rubies into master

Created by: cirosantilli

Would fail because Git modifies the hooks PATH, so for example the at /usr/bin/ruby could be called instead of the correct one at /usr/local/bin/ruby. Same for RVM.

Updates the reversed https://github.com/gitlabhq/gitlabhq/pull/8340 , same goals.

Requires: https://github.com/gitlabhq/gitlab-shell/pull/199/files

The new approach is to generate a file to be sourced with the PATH for gitlab shell on gitlab's startup, much like .gitlab_shell_secret.

Old approach with env vars failed because SSH does not pass through GitLab so the vars were not being set.

Tests were removed since they were breaking something on the GitLab internal server. I can add again if desired.

Merge request reports