Skip to content

Fix invalid GitHub `authorize_url`.

Matthias Käppler requested to merge github/fork/ykzts/fix-github-authorize_url into master

Created by: ykzts

$ ./bin/rspec ./spec/lib/gitlab/github_import/client_spec.rb
F

Failures:

  1) Gitlab::GithubImport::Client #authorize_url
     Failure/Error: expect(client.authorize_url("https://app.com")).to eq(authorize_url)

       expected: "https://github.com/login/oauth/authorize?response_type=code&client_id=YOUR_APP_ID&redirect_uri=https%3A%2F%2Fapp.com&scope=repo%2C+user%2C+user%3Aemail"
            got: "https://api.github.com/oauth/authorize?response_type=code&client_id=YOUR_APP_ID&redirect_uri=https%3A%2F%2Fapp.com&scope=repo%2C+user%2C+user%3Aemail"

       (compared using ==)
     # ./spec/lib/gitlab/github_import/client_spec.rb:12:in `block (2 levels) in <top (required)>'
     # -e:1:in `<main>'

Finished in 5.87 seconds
1 example, 1 failure

Failed examples:

rspec ./spec/lib/gitlab/github_import/client_spec.rb:4 # Gitlab::GithubImport::Client test

Merge request reports