Skip to content

User pages are public

Matthias Käppler requested to merge github/fork/booktree/public-user-pages into master

Created by: cirosantilli

Fixes ACCEPTING MERGE/PULL REQUESTS at http://feedback.gitlab.com/forums/176466-general/suggestions/5374154-create-a-public-index-of-users-and-let-users-be-pu.

Behaviour Changes

  • current user profile pages at u/:username can be visited seen by any user without login.
  • only projects and project events that the logged in user can see are listed.

The content of the page is otherwise unchanged, except of course the public header in case the user is not logged in.

Screenshots

  • u/:username while signed out:

screenshot from 2014-01-27 18 21 45 signed out

  • u/:username while signed in as someone else:

screenshot from 2014-01-27 18 26 15 signed in as someone else

  • u/:username while signed as the user himself:

screenshot from 2014-01-27 18 26 54 signed in as the user

Implementation notes

Factored out test User creation under group and admin/group into shared/user. Used name "John Doe" everywhere instead of just "John" to keep uniformity with projects.

Part of features/steps/public/projects_feature.rb spilled out to shared/project.rb since it is now used in both Public projects and User tests.

CSS class header.project_name renamed to .title since it can now contain both project names and user names.

Please consider merging this other MR as it would make it much easier to do interactive tests and screenshots that depend on having multiple project visibility levels.

Merge request reports