Skip to content

Fix argument parser being unable to handle options with arguments

James Nutt requested to merge dj-fix-omnibus-issue-4 into master
  • Extract logic for removing GitLab QA args into a class method Runner.remove_gitlab_qa_args.
  • remove_gitlab_qa_args() will take a set of arguments and remove any argument that is specific to GitLab QA. This was necessary since there is a difference between options with arguments and options without.

Previously, we were only removing only the options, leaving the arguments behind, resulting in packages and object_storage arguments ultimately being passed into the RSpec runner, causing Issue 4 of the Omnibus Epic

Edited by James Nutt

Merge request reports

Loading