Skip to content
Snippets Groups Projects
GitLab Community Edition

GitLab Community Edition

Project ID: 2003893
Select Git revision
  • move-gl-dropdown
  • improve-table-pagination-spec
  • move-markdown-preview
  • winh-fix-merge-request-spec
  • master default
  • index-namespaces-lower-name
  • winh-single-karma-test
  • 10-3-stable
  • 36782-replace-team-user-role-with-add_role-user-in-specs
  • winh-modal-internal-state
  • tz-ide-file-icons
  • 38869-milestone-select
  • update-autodevops-template
  • jivl-activate-repo-cookie-preferences
  • qa-add-deploy-key
  • docs-move-article-ldap
  • 40780-choose-file
  • 22643-manual-job-page
  • refactor-cluster-show-page-conservative
  • dm-sidekiq-versioning
  • v10.4.0.pre
  • v10.3.0
  • v10.3.0-rc5
  • v10.3.0-rc4
  • v10.3.0-rc3
  • v10.3.0-rc2
  • v10.2.5
  • v10.3.0-rc1
  • v10.0.7
  • v10.1.5
  • v10.2.4
  • v10.2.3
  • v10.2.2
  • v10.2.1
  • v10.3.0.pre
  • v10.2.0
  • v10.2.0-rc4
  • v10.2.0-rc3
  • v10.1.4
  • v10.2.0-rc2
40 results
  • Clone with SSH
  • Clone with HTTPS
  • Forked from GitLab.org / GitLab FOSS
    Source project has a limited visibility.
    user avatar
    Pierre de La Morinerie authored
    `MergeRequest#source_sha` is expected to return the sha of the source
    branch last commit.
    
    But when a open Merge Request has no diff (e.g. all commits have already
    been merged to the target branch), `merge_request.source_sha`
    incorrectly returns `nil`.
    
    This was un-noticed before – but now that !2217 has been merged,
    it makes `Gitlab::Git::Commit.between` raise an
    "Unexpected nil argument" exception.
    
    This fixes the crash, by making sure that `source_sha` returns a
    correct result even when there is no diff available.
    18295585
    History
    Name Last commit Last update