Skip to content

Odf conditional format

username-removed-521739 requested to merge jvsg/orcus:odf-conditional-format into master

@moggi , The top 9 commits are the ones to be reviewed if the previous merge request hasn't been merged.Please review this whenever you get time. On building this , I get the following warning ,

odf_styles_context.cpp: In member function 'virtual void orcus::styles_context::start_element(orcus::xmlns_id_t, orcus::xml_token_t, const std::vector<orcus::xml_token_attr_t>&)':
odf_styles_context.cpp:390:7: warning: 'func' may be used uninitialized in this function [-Wmaybe-uninitialized]
 class map_prop_attr_parser : std::unary_function<xml_token_attr_t, void>
       ^
odf_styles_context.cpp:777:38: note: 'func' was declared here
                 map_prop_attr_parser func;
                                      ^
odf_styles_context.cpp:390:7: warning: '*((void*)& func +4)' may be used uninitialized in this function [-Wmaybe-uninitialized]
 class map_prop_attr_parser : std::unary_function<xml_token_attr_t, void>
       ^
odf_styles_context.cpp:777:38: note: '*((void*)& func +4)' was declared here
                 map_prop_attr_parser func;
                                      ^

However the code works fine and passes tests. Should this warning be ignored ? How could I initialize it considering that objects of other such classes aren't initialized as well?

Thanks.

Merge request reports