Skip to content

Simplify tests verifying the modules

username-removed-214013 requested to merge xZise/flake8-polyfill:simplify-checks into master

The test which verifies the modules dict first checked if the length was correctly set and then checked the contents. But by checking the contents it also checks the length so that check is obsolete. Additional does the check of two lists show explicitly which elements are different between the lists:

>       assert stdin.modules['pep8'] == [pep8]
E       assert [<module 'pep...8.py'>, False] == [<module
'pep8...ges/pep8.py'>]
E         Left contains more items, first extra item: False
E         Use -v to get the full diff

But the original implementation at least shows the content of the list:

>       assert len(stdin.modules['pep8']) == 1
E       assert 2 == 1
E        +  where 2 = len([<module 'pep8...8.py'>, False])

Merge request reports