Skip to content

Revert "Warn users when overriding methods (via let, def or define_method) in the same example group."

gitlab-qa-bot requested to merge revert-method-override-warning into master

Created by: myronmarston

This reverts the lib and spec pieces of e072e535.

The warning is overzealous. After upgrading a project to RSpec HEAD, I got spammed with tons of warnings of situations that weren't actually problematic. For example, it's common to define a let in a shared context that provides a default value, and than to purposefully override that in a host group where the shared context is included. We shouldn't warn in such a situation, but this did warn.

See #1903 for the original code this reverts.

/cc @fabn

Merge request reports