Skip to content

(refactor): Avoid calling superclass.method

gitlab-qa-bot requested to merge github/fork/dgmstuart/avoid-superclass-method-call into master

Created by: dgmstuart

...in favour of using a lambda.

This addresses https://github.com/rspec/rspec-core/issues/2008

But really, any third party code which causes problems with the original code is probably doing something a bit dodgy (e.g. overriding the method method on an object).

Core test suite passes locally, but I haven't been able to run the travis build locally because of the following (unrelated) error:

» script/run_build
============= Starting binstub check ===============
Checking required binstubs
============= Ending binstub check ===============
============= Starting specs ===============
/Users/dxwduncan/dev/ruby_and_rails/rspec-core/bin/rspec
script/rspec_with_simplecov:17:in `require': cannot load such file -- bundler/setup (LoadError)
        from script/rspec_with_simplecov:17:in `<main>'

(I'm using bundler 1.10.6)

Merge request reports