Skip to content

Squat on less of the user's method namespace.

gitlab-qa-bot requested to merge less-namespace-squatting into master

Created by: myronmarston

RSpec::Mocks::ExampleMethods is mixed into a context where users freely define their own methods. As such, it's best to not define private helper methods as the user may inadvertently overwrite them. These methods were all stateless, anyway, so they work equally well as class methods and this creates less surface area for override problems.

Merge request reports