Skip to content

WIP: Cleanup cukes

gitlab-qa-bot requested to merge cleanup-cukes into master

Created by: myronmarston

This is the work I've done so far for #591 (closed). I'm not done yet but it's at a point where it's worth getting feedback.

My focus here is on making are relish docs really first-class, where they are written to read as documentation first, and to serve as regression tests second. (I feel like our spec coverage is generally good enough for most things.)

I've been using a staging environment to preview how this renders on relish, making sure it looks good as I go:

https://relishapp.com/rspec-staging/rspec-mocks/docs

There are still some of the old cukes in features-old. As I've been going along I've been deleting ones that were either covered by new cukes (in features) or that I was sure had spec coverage. The ones that are left are ones we need to look into a bit more.

Still TODO:

  • Add a README.md file for the basics directory. Not sure what to put in there yet given there's already a root README with the same kind of info.
  • Add a section for the old :should syntax (see #591 (closed) for an early idea of what this would be).
  • Add an "outside rspec" section (again, see #591 (closed))
  • Deal with the rest of the features-old cukes (migrating them to specs as necessary to provide missing coverage).

Merge request reports