Skip to content

A fix for #972

gitlab-qa-bot requested to merge samphippen/fix-972 into master

Created by: penelopezone

It seemed to me that if the problem is creating superclass proxies, then we could just add a method and put a flag in to the constructors to fix this. The current fix is a bit shonky, but demonstrates the solution.

I have some questions/thoughts:

  1. Perhaps, this behaviour change should be extracted out in to an object, as opposed to a conditional. We'd inject a callbacks collaborator into the proxies which they would then invoke
  2. Perhaps this should be flag on proxy_for instead of adding a new method?
  3. I think the verifying class proxy is the only place we need to put the flag, but is that correct?

This fix is really simple, but I'm not sure it's architecturally brilliant. Thoughts?

Merge request reports