Skip to content

tools: adding osx-uninstall script

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

tools

Description of change

This is the first steps in adding an uninstaller for node and is referencing issue: https://github.com/nodejs/node/issues/7371

As seen in the discussion, 2 ways of going about this were brought up. One is adding an uninstall command to node itself and another is adding documentation to just trigger this bash script. My feeling is if we add the curl / bash script pointing to this file to uninstall to Nodejs.org would be the solution for the time being.

As for the reason this should be in node core: As node changes this file should change to remove any new file references to node. Thus having this in a committed file with history vs a public gist seems like a better way to store it.

If this gets merged i will open a PR on nodejs.org with a short snippet to nodejs.org install page under mac for how to uninstall.

As mentioned in the commit, this is based off @rvagg 's Gist from IO.js's repo:

https://github.com/rvagg/io.js/blob/fhemberger-refactor-mac-installer-rebase/tools/osx-pkg/scripts/uninstall.sh

Discussion/Guidance welcome!

Merge request reports

Loading