Skip to content

http: Eliminate ClientRequest capture by Agent socket listeners

Rodrigo Muino Tomonari requested to merge github/fork/evantorrie/agent-retainer into master
Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

http

Description of change

Eliminate capture of createSocket callback in onFree/onClose/onRemote listeners by moving them to a separate function.

Fixes #10133 (closed)

This reduces the heap usage by eliminating the capture in a prior context of the ClientRequest object associated with the first call that opens a socket. Let me know the best way to provide tests for this, as it's non-obvious to me how to do so.

I have provided a heapsnapshot screen shot in the accompanying issue (#10133 (closed)), and will attach a similar heapsnapshot screen shot showing usage after this fix is included. heap_noretainer

Merge request reports