Skip to content

test: fix flaky test-net-socket-timeout

Rodrigo Muino Tomonari requested to merge github/fork/Trott/socket-timeout into master
Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test net

Description of change

The setTimeout() call is unneeded. If the socket never times out, then the test will never finish. Because timers can be unreliable on machines under load, using setTimeout() here effectively creates a race condition.

Merge request reports