Skip to content

doc: clarify the review and landing process

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

A few process-related details are only explained in the onboarding guide and the collaborator's guide. Mentioning them in the contributing guide as well can avoid confusions to new contributors. This is based on my previous experience, but I am still a new contributor myself, so feel free to correct me if my understanding is not the case!

  • Explains what "nits" stand for
  • Explains commit squashing
  • Mention the CI run
  • Mention the mandatory 48/72 hours wait

Ref: https://github.com/nodejs/node/pull/10151

Merge request reports

Loading