Skip to content

deps: backport f795a79 from upstream V8

Rodrigo Muino Tomonari requested to merge github/fork/targos/v6.x-fix-10347 into v6.x-staging
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

v8

Description of change

Original commit message:

    Rewrite scopes in computed properties in destructured parameters

    While we properly handled scopes of initializers in destructured
    parameters,
    we never did the right thing for computed properties. This patch
    fixes that
    by factoring out PatternRewriter's scope rewriting logic and calls
    it for the computed property case.

    BUG=chromium:620119

    Review-Url: https://codereview.chromium.org/2084103002
    Cr-Commit-Position: refs/heads/master@{#37228}

Fixes: https://github.com/nodejs/node/issues/10347

Merge request reports