Skip to content

async_wrap: clear destroy_ids vector

Rodrigo Muino Tomonari requested to merge github/fork/trevnorris/fix-no-destroy-called into master
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

async_wrap

Description of change

After processing all the callbacks in the destroy_ids vector make sure to clear() it otherwise the DestroyIdsCb() won't run again.

This patch should land on all releases that have b49b496a, or some cherry-pick of it.

CI: https://ci.nodejs.org/job/node-test-commit/6782/

Merge request reports