Skip to content

url: check MaybeLocal return value

Rodrigo Muino Tomonari requested to merge github/fork/trevnorris/no-url-compile-warn into master
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

url

Description of change

Always check the return value for V8 APIs that return a v8::MaybeLocal.

Fixes: 4b312387 "url: adding WHATWG URL support"

CI: https://ci.nodejs.org/job/node-test-commit/6785/

NOTE: Not a fan of simply ignoring whether the callback threw or not, but if we're going to use the MaybeLocal API then we shouldn't be using it in a way that creates a compiler warning. So I'm up for suggestions on how we should check it.

Merge request reports