Skip to content

build: don't squash signal handlers with --shared

Rodrigo Muino Tomonari requested to merge github/fork/sxa/sharedlib-signalsquash into master
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

build

Fixes: https://github.com/nodejs/node/issues/10520 Ref: https://github.com/nodejs/node/commit/dd47a8c78547db14ea0c7fc2f3375e8c9cb1a129

An application using node built as a shared library may legitimately implement it's own signal handling routines. Currenty behaviour is to squash all signal handlers on node startup. This change will stop that behaviour when node is built as a shared library.

(Haven't yet checked with the person that raised the problem with me as they're currently on vacation, but this appears to resolve the problem as I understood it from them!)

Merge request reports