Skip to content

url: TupleOrigin#toString use unicode by default

See: https://url.spec.whatwg.org/#dom-url-origin

Also moves the tests for origins to the parsing tests since now URL#origin matches the test cases by default.

Aside: maybe the unicode argument can be removed since from what I've found so far the spec doesn't use domain to ASCII serialization for origins and https://coverage.nodejs.org/coverage-abc1633de649bfa5/root/internal/url.js.html shows that the unicode === false is never taken in tests.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

url

cc / @jasnell

Merge request reports

Loading