Skip to content

events: avoid emit() eager deopt

Rodrigo Muino Tomonari requested to merge github/fork/vhf/fix-eventemitter-emit-deopt into master

This commit makes sure EventEmitter.emit() doesn't get deoptimized by V8. The deopt happens when accessing out of bound indexes of the arguments object.

This issue has been raised here: https://github.com/nodejs/node/issues/10323 and this specific case might become a more serious performance issue in upcoming V8 releases.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)
  • events
  • @nodejs/v8

Merge request reports