Skip to content

build: don't bundle deps/zlib if --shared-zlib set

Rodrigo Muino Tomonari requested to merge github/fork/gibfahn/share-zlib into master

Even if the --shared-zlib flag was used, the bundled deps/zlib was still being compiled into the binary as it was required by the C++ test suite.

Fixes: https://github.com/nodejs/node/issues/10649

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

build, zlib

cc/ @bnoordhuis

Merge request reports

Loading