Skip to content

deps: V8: fix backtrace for symbols

Rodrigo Muino Tomonari requested to merge github/fork/ofrobots/symbols-backtrace into v4.x-staging

The cherry-pick of #7612 to v4.x (43690558) added in #9298 wasn't quite correct as it depends on a runtime function %SymbolDescriptiveString that doesn't exist on v4.x (V8 4.5). We can use %SymbolDescription instead.

It seems that the V8-CI was missed when when the #7612 was backported to v4.x so we didn't catch it at that point. At this point however, the V8-CI is no longer passing because of the V8 test failures caused by the above.

R=@hashseed, @nodejs/v8 /cc @MylesBorins

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

deps: V8

Merge request reports