Skip to content

V4 backport: don't squash signal handlers with --shared

Rodrigo Muino Tomonari requested to merge github/fork/sxa/v4.x-signalsquash into v4.x-staging
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

build

An application using node built as a shared library may legitimately
implement its own signal handling routines. Current behaviour is
to squash all signal handlers on node startup. This change will
stop that behaviour when node is built as a shared library.

PR-URL: https://github.com/nodejs/node/pull/10539
Fixes: https://github.com/nodejs/node/issues/10520
Refs: https://github.com/nodejs/node/pull/615
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

PR to backport https://github.com/nodejs/node/commit/0f0f3d33309d3382deb33825fdffeb048f80ec18 to which won't land cleanly on v4.x. It would be good if we can squeeze this one into the 4.8.0.0 release - it adds an #ifdef which is specific to the build with --shared so should be low risk and I have some users using the shared library with v4.x who have experienced problems with this.

Smiles sweetly at @MylesBorins :-)

Merge request reports