Skip to content

src: fix mismatched delete[] in src/node_file.cc

Rodrigo Muino Tomonari requested to merge github/fork/bnoordhuis/fix-bad-delete into v1.x

Fix a bad delete of a pointer that was allocated with placement new. Casting the pointer was not the right solution because there was at least one non-placement new constructor call.

This commit rewrites FSReqWrap to be more explicit about ownership of the auxiliary data and removes a number of egregious const_casts. The ASYNC_DEST_CALL macro also gets significantly slimmed down.

R=@indutny

Is there a bug number I should reference in the commit log?

https://jenkins-iojs.nodesource.com/view/iojs/job/iojs+any-pr+multi/257/

Merge request reports