Skip to content

test: verify shell option internals

Rodrigo Muino Tomonari requested to merge github/fork/cjihrig/shell into master

This commit adds code coverage to the internals associated with the child_process shell option. This achieves the following:

  • Increased code coverage, which is currently only reported for Unix.
  • Ensures that all six code paths are covered, including the three Windows variations, and Android which is not tested at all on CI.
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

CI: https://ci.nodejs.org/job/node-test-pull-request/5999/ CI: https://ci.nodejs.org/job/node-test-pull-request/6001/

Merge request reports