Skip to content

http: add doc deprecation for private props

Rodrigo Muino Tomonari requested to merge github/fork/mscdex/http-outgoingmessage-headers-deprecate into master

This is one proposed solution to the current backwards compatibility issue (see https://github.com/nodejs/node/pull/10558) in master with end users who directly access outgoingMessage._headers/outgoingMessage._headerNames.

This PR will be simplified some once https://github.com/nodejs/node/pull/10805 is landed (which should land before this PR). Specifically, the ._headers getter can simply just return this.getHeaders().

/cc @nodejs/collaborators

CI: https://ci.nodejs.org/job/node-test-pull-request/6054/

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)
  • http

Merge request reports