Skip to content

url: make URLSearchParams properties spec-compliant

Rodrigo Muino Tomonari requested to merge github/fork/TimothyGu/urlsearchparams-props into master

Define URLSearchParams methods as enumerable, writable, configurable, as have already been done to URL in #10408. Also adjust the @@toStringTag variable, as done to URL in #10906.

Fixes: #10799 (closed)

Benchmark (no significant differences) 
                                                              improvement confidence   p.value
 url/url-searchparams-parse.js n=100000 type="encodelast"          0.96 %            0.5252137
 url/url-searchparams-parse.js n=100000 type="encodemany"         -1.82 %            0.1068003
 url/url-searchparams-parse.js n=100000 type="manypairs"          -0.32 %            0.5695471
 url/url-searchparams-parse.js n=100000 type="multicharsep"       -0.65 %            0.4697857
 url/url-searchparams-parse.js n=100000 type="multivalue"         -1.08 %            0.4232083
 url/url-searchparams-parse.js n=100000 type="multivaluemany"     -1.11 %            0.1315487
 url/url-searchparams-parse.js n=100000 type="noencode"            0.19 %            0.8053736
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

url

Merge request reports