Skip to content

test: add --abort-on-timeout option to test.py

Rodrigo Muino Tomonari requested to merge github/fork/misterdjules/tests-kill-abort into master

test: add --abort-on-timeout option to test.py

Currently, when a process times out, it is terminated by sending it the SIGTERM signal. Sending SIGBART instead allows the operating system to generate a core file that can be investigated later using post-mortem debuggers such as llnode or mdb_v8.

This can be very useful when investigating flaky tests that time out, since in that case the failure is difficult to reproduce, and being able to look at a core file makes a big difference.

With these changes, passing the --abort-on-timeout command line option to tools/test.py now sends SIGABRT to processes timing out on all platforms but Windows.

Refs: https://github.com/nodejs/node/issues/11026

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

/cc @nodejs/testing

Merge request reports