Skip to content

build: add rule to clean addon tests build

Rodrigo Muino Tomonari requested to merge github/fork/joyeecheung/clean-addons into master

Add a rule to the makefile to clean up files generated during testing addons.

Note: when switching from a newer branch, where the addon tests have been built, to an older branch that don't have some of the addon tests, there would be leftover build directories in those test folders.

$ ls test/addons/node-module-version/
binding.cc  binding.gyp build test.js
$ git checkout v4.8.0
$ ls test/addons/node-module-version/
build

test/addons/.buildstamp would try to use node-gyp to build them, only to find the binding.gyp missing. If we run this rule before switching branches, there won't be leftover build and those test folders would not be kept when the branches are switched. I think the test/addons/.buildstamp can have some kind of conditions to avoid that or just delete folders with only build, but not sure what's the appropriate way to do this.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

build

Merge request reports