Skip to content

http: add flushHeaders and deprecate flush

Rodrigo Muino Tomonari requested to merge github/fork/yosuke-furukawa/fix/add_alias_http_flush_headers into v1.x

I found a different API from Node.js v0.12 and io.js. the detail is here https://github.com/joyent/node/commit/89f3c9037faf19eb32c464b2e02a0a9191156c36

http module in io.js has a method req.flush. Node.js v0.12 also has a same behavior method but the different name req.flushHeaders.

the difference may cause to block migrations from Node.js v0.12 to io.js. But if we rename req.flush to req.flushHeaders now, we should update the major version.

So I add req.flushHeaders method and deprecate req.flush.

If we bump the io.js master version, we would be better to rethink req.flush is removed.

Merge request reports